Hello and welcome to our community! Is this your first visit?
Register
Results 1 to 7 of 7

Thread: inGenerality

  1. #1
    Fanatic Enthusiast Gabe.'s Avatar

    Join Date
    Dec 2008
    Location
    South Florida
    Posts
    2,689

    inGenerality

    http://www.ingenerality.byethost16.com/
    This is a personal site, I use it to brush up and improve my coding skills.

    I used:
    - XHTML
    - CSS
    - Very basic JavaScript

    If any of you (Skype or Adam mostly, haha) would give some criticism on the code or the design, it would be much appreciated.
    [center:2sk2z7an]"Opportunity is everywhere, and can take you anywhere."[/center:2sk2z7an]
    [center:2sk2z7an]Thread[/center:2sk2z7an]

  2. #2
    Insanity Skype's Avatar



    Join Date
    Apr 2007
    Location
    England
    Posts
    27,397

    Re: inGenerality

    Well there's not really a nice way to sum up the theme overall, but it's really bad.

    The colours are terrible, it's too sore on the eyes. Imo you should never use black and white together, at least not to that extreme ( IE, use light greys and dark greys, if you're gonna use black/white ).

    The layout itself is.... Mediocre. It has the potential to be appealing but the way you went about doing it is rather bad. I'd suggest you start by centering it.

    The type face for the header is bad, change it. Or make a nice header in photoshop.

    Your code is very messy, and you've made a lot of mistakes that wont validate. I suggest you wrap everything in a global div, like <div id="wrapper"> ( look at my site ) as it means you can control the width of everything easily. And I noticed you used javascript to display the date, an easier way to do this would be with PHP.

    http://php.net/manual/en/function.date.php

    Where you have

    Code:
    <div id="nav">
    
    		<ul>Home[/list]
    		<ul>Forums[/list]
    		<ul>Work[/list]
    		<ul>About[/list]
    
    		<ul>Contact Me[/list]
    	
    </div>
    Generally you'd have all of the nav elements in a <ul> tag, then separate links in[*] tags, like this:

    Code:
    <div id="nav">
    
              <ul>
    
    		[*]Home
    		[*]Forums
    		[*]Work
    		[*]About[*]Contact Me
    [/list]
    	
    </div>
    There's also a bug where you have to hover near the top of the nav links for them to be clickable.

    So yeah, you can tell you're a novice. You have a lot to work on.

  3. #3
    Obsessed Veteran Adam's Avatar



    Join Date
    Nov 2004
    Location
    UK / England
    Posts
    17,271

    Re: inGenerality

    In regards to the quality of the CSS here's some pointers.

    Your using absolute positioning for most of the elements this really isn't required for this type of layout. Avoid using font-size: px, all font sizes should be percents and in the body you have an em font size value.

    You should also correctly inherit your css as needed;

    #div #div #div .class ul etc


    Not bad for stating out though.

  4. #4
    Fanatic Enthusiast

    Join Date
    Oct 2007
    Location
    UK
    Posts
    4,598

    Re: inGenerality

    Apart from the obvious stuff that Skype and Adam pointed out, it's not a bad design. If you put a little bit more work into it, added some more appropriate coloring, and fixed the header (through my eyes that big block at the top just looks empty and out of place, I suggest making a nice image the width of your initial content area instead of dragging it across the date and affiliates.) you'd have yourself something to be proud of.

    I'd also like to point out for you

    <ul> starts an un-ordered list[*] is an item in the list

    by default lists are set as they are on forums;

    • Item 1 [/*:m:3rznkk0u]
    • Item 2[/*:m:3rznkk0u]
    • Item 3[/*:m:3rznkk0u]


    so you might wanna go ahead and style (or un-style as it were) your li element with

    {
    list-style: none;
    }

    which will just remove the bullet points and ect.

    EDIT: got bored, but thats what I mean with the header n shit

    http://pimp.darkdemon.org/8407/1261997097.png

  5. #5
    Fanatic Enthusiast Gabe.'s Avatar

    Join Date
    Dec 2008
    Location
    South Florida
    Posts
    2,689

    Re: inGenerality

    Alright, thanks, I appreciate the comments, I'll work on them.
    [center:2sk2z7an]"Opportunity is everywhere, and can take you anywhere."[/center:2sk2z7an]
    [center:2sk2z7an]Thread[/center:2sk2z7an]

  6. #6
    Veteran Enthusiast LeadingManNigel's Avatar


    Join Date
    May 2005
    Location
    New York City
    Posts
    6,213

    Re: inGenerality

    Looks better than my first template lol, good to see more people doing stuff like this its fun to watch them grow.

  7. #7
    Fanatic Enthusiast

    Join Date
    Mar 2008
    Posts
    2,536

    Re: inGenerality

    Your background houses sharp edges and noise that starts in randoms places.


 

Posting Permissions

  • You may not post new threads
  • You may not post replies
  • You may not post attachments
  • You may not edit your posts
  •